Closed CyberHoward closed 1 month ago
Latest commit: |
8d9fb72
|
Status: | ✅ Deploy successful! |
Preview URL: | https://e7402de0.cw-orchestrator.pages.dev |
Branch Preview URL: | https://sender-refactor.cw-orchestrator.pages.dev |
Attention: Patch coverage is 59.37500%
with 260 lines
in your changes missing coverage. Please review.
Project coverage is 54.7%. Comparing base (
90bc67b
) to head (8d9fb72
).
Still need to update docs
This PR refactors the way that the Sender objects are constructed and configured.
The initial PR added a
SenderTrait::SenderOptions
associated type that allow for building aSender
object.First, I renamed a few of the traits, types and methods to improve the clarity of the code's structure. Then I split up the
SenderTrait
intoSenderBuilder
,QuerySender
andTxSender
, each with their own scoped functions and types.With this I refactored the
DaemonBuilder
(s) to now work as follows:Checklist