Closed Buckram123 closed 1 month ago
Robin did mention that it's generally better to accept Into<String>
instead of impl ToString
, so another breaking thing to consider that we could do in this PR is replacing to impl Into<String>
(not for Addrs, but for path, client_id, etc..)
Latest commit: |
1d44f0c
|
Status: | ✅ Deploy successful! |
Preview URL: | https://7faf3a65.cw-orchestrator.pages.dev |
Branch Preview URL: | https://buckram-cosmwasm2-accept-add.cw-orchestrator.pages.dev |
Attention: Patch coverage is 47.18310%
with 75 lines
in your changes missing coverage. Please review.
Project coverage is 51.1%. Comparing base (
9cea8d4
) to head (1d44f0c
). Report is 1 commits behind head on update/cosmwasm-std-2.
Robin did mention that it's generally better to accept
Into<String>
instead ofimpl ToString
, so another breaking thing to consider that we could do in this PR is replacing toimpl Into<String>
(not for Addrs, but for path, client_id, etc..)
Can we do that in a different PR?
Merge into #390 MockApi now accepts only valid Bech32 addrs, so it doesn't make sense to accept anything except Addr anymore
Checklist