AbstractSDK / cw-orchestrator

All-in-one Rust-based CosmWasm testing, scripting, and deployment tool.
https://orchestrator.abstract.money
GNU General Public License v3.0
76 stars 18 forks source link

Cosmwasm2 accept addr #467

Closed Buckram123 closed 1 month ago

Buckram123 commented 1 month ago

Merge into #390 MockApi now accepts only valid Bech32 addrs, so it doesn't make sense to accept anything except Addr anymore

Checklist

Buckram123 commented 1 month ago

Robin did mention that it's generally better to accept Into<String> instead of impl ToString, so another breaking thing to consider that we could do in this PR is replacing to impl Into<String> (not for Addrs, but for path, client_id, etc..)

cloudflare-pages[bot] commented 1 month ago

Deploying cw-orchestrator with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1d44f0c
Status: ✅  Deploy successful!
Preview URL: https://7faf3a65.cw-orchestrator.pages.dev
Branch Preview URL: https://buckram-cosmwasm2-accept-add.cw-orchestrator.pages.dev

View logs

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 47.18310% with 75 lines in your changes missing coverage. Please review.

Project coverage is 51.1%. Comparing base (9cea8d4) to head (1d44f0c). Report is 1 commits behind head on update/cosmwasm-std-2.

Files Patch % Lines
cw-orch-daemon/src/queriers/staking.rs 0.0% 15 Missing :warning:
cw-orch-daemon/src/senders/cosmos_options.rs 28.5% 10 Missing :warning:
cw-orch-daemon/src/live_mock.rs 40.0% 6 Missing :warning:
cw-orch-daemon/src/queriers/cosmwasm.rs 40.0% 6 Missing :warning:
cw-orch-daemon/src/queriers/feegrant.rs 0.0% 6 Missing :warning:
cw-orch-daemon/src/queriers/gov.rs 0.0% 6 Missing :warning:
cw-orch-daemon/src/senders/cosmos.rs 37.5% 5 Missing :warning:
...kages/cw-orch-core/src/environment/queriers/mod.rs 28.5% 5 Missing :warning:
cw-orch-daemon/src/sync/core.rs 0.0% 4 Missing :warning:
packages/interchain/starship/src/client/faucet.rs 0.0% 4 Missing :warning:
... and 5 more
Additional details and impacted files | [Files](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/467?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK) | Coverage Δ | | |---|---|---| | [contracts/mock\_contract/src/lib.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/467?src=pr&el=tree&filepath=contracts%2Fmock_contract%2Fsrc%2Flib.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y29udHJhY3RzL21vY2tfY29udHJhY3Qvc3JjL2xpYi5ycw==) | `97.3% <100.0%> (ø)` | | | [cw-orch-daemon/src/queriers/authz.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/467?src=pr&el=tree&filepath=cw-orch-daemon%2Fsrc%2Fqueriers%2Fauthz.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y3ctb3JjaC1kYWVtb24vc3JjL3F1ZXJpZXJzL2F1dGh6LnJz) | `91.3% <100.0%> (ø)` | | | [cw-orch-daemon/src/queriers/bank.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/467?src=pr&el=tree&filepath=cw-orch-daemon%2Fsrc%2Fqueriers%2Fbank.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y3ctb3JjaC1kYWVtb24vc3JjL3F1ZXJpZXJzL2JhbmsucnM=) | `90.5% <100.0%> (-0.3%)` | :arrow_down: | | [cw-orch-daemon/src/sync/builder.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/467?src=pr&el=tree&filepath=cw-orch-daemon%2Fsrc%2Fsync%2Fbuilder.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y3ctb3JjaC1kYWVtb24vc3JjL3N5bmMvYnVpbGRlci5ycw==) | `84.2% <100.0%> (+0.1%)` | :arrow_up: | | [cw-orch-daemon/src/tx\_builder.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/467?src=pr&el=tree&filepath=cw-orch-daemon%2Fsrc%2Ftx_builder.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-Y3ctb3JjaC1kYWVtb24vc3JjL3R4X2J1aWxkZXIucnM=) | `70.9% <100.0%> (+0.6%)` | :arrow_up: | | [...ages/cw-orch-core/src/environment/queriers/wasm.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/467?src=pr&el=tree&filepath=packages%2Fcw-orch-core%2Fsrc%2Fenvironment%2Fqueriers%2Fwasm.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-cGFja2FnZXMvY3ctb3JjaC1jb3JlL3NyYy9lbnZpcm9ubWVudC9xdWVyaWVycy93YXNtLnJz) | `100.0% <100.0%> (ø)` | | | [packages/cw-orch-mock/src/core.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/467?src=pr&el=tree&filepath=packages%2Fcw-orch-mock%2Fsrc%2Fcore.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-cGFja2FnZXMvY3ctb3JjaC1tb2NrL3NyYy9jb3JlLnJz) | `96.4% <100.0%> (ø)` | | | [packages/cw-orch-mock/src/queriers/bank.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/467?src=pr&el=tree&filepath=packages%2Fcw-orch-mock%2Fsrc%2Fqueriers%2Fbank.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-cGFja2FnZXMvY3ctb3JjaC1tb2NrL3NyYy9xdWVyaWVycy9iYW5rLnJz) | `92.8% <100.0%> (ø)` | | | [packages/cw-orch-mock/src/queriers/wasm.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/467?src=pr&el=tree&filepath=packages%2Fcw-orch-mock%2Fsrc%2Fqueriers%2Fwasm.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-cGFja2FnZXMvY3ctb3JjaC1tb2NrL3NyYy9xdWVyaWVycy93YXNtLnJz) | `88.4% <100.0%> (-0.5%)` | :arrow_down: | | [packages/interchain/interchain-core/src/env.rs](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/467?src=pr&el=tree&filepath=packages%2Finterchain%2Finterchain-core%2Fsrc%2Fenv.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK#diff-cGFja2FnZXMvaW50ZXJjaGFpbi9pbnRlcmNoYWluLWNvcmUvc3JjL2Vudi5ycw==) | `70.6% <ø> (ø)` | | | ... and [15 more](https://app.codecov.io/gh/AbstractSDK/cw-orchestrator/pull/467?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AbstractSDK) | |
CyberHoward commented 1 month ago

Robin did mention that it's generally better to accept Into<String> instead of impl ToString, so another breaking thing to consider that we could do in this PR is replacing to impl Into<String> (not for Addrs, but for path, client_id, etc..)

Can we do that in a different PR?