search

AcK77 / AmiiBomb-uino

Amiibo Cloning with Arduino
218 stars 70 forks source link

Update MFRC522 Library #17

Open xrobau opened 7 years ago

xrobau commented 7 years ago

As per the comment in https://gbatemp.net/threads/tools-amiibomb.467990/page-27#post-7516237 I updated the MFRC522 library. Seems to work fine.

xrobau commented 7 years ago

However, after viewing the diff, it appears to be missing the 'Magic' section of code here - Does this need to be re-added?

(Note I didn't try writing)

peacepenguin commented 7 years ago

the magic section was moved to a new file in the upstream library: MFRC522hack.h being that it is for "hackable" cards that aren't within the spec, so the library was moved to a "hackable" library that also doesn't follow the spec.

Since amiibomb doesn't currently use any of the MAGIC functions for resetting UID cards, its fine to leave out for now, at some point if/when the "reset hackable cards" feature is added to amiibomb then the MFRC522hack library can be added then.

I've built successfully with the updated lib, and without the hack.h file.

I don't think the MFRC522debug library should be included though, IMO.