AcademySoftwareFoundation / Imath

Imath is a C++ and python library of 2D and 3D vector, matrix, and math operations for computer graphics

https://imath.readthedocs.io

BSD 3-Clause "New" or "Revised" License

356 stars 104 forks source link

src/python/config: do not install a cmake file exporting targets for dependent projects #361

Closed josch closed 5 months ago

josch commented 5 months ago

Before this change, projects using imath via cmake also had python bindings automatically added even if they are not needed. I rebuilt all 134 source packages in Debian unstable which directly or indirectly pull in imath to make sure that this change does not break anything. Naturally there are more software packages out there but the selection of 134 not breaking makes me sufficiently confident that this change doesn't break other software.

Thanks: Jochen Sprickerhof Closes: #360

linux-foundation-easycla[bot] commented 5 months ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: josch (e79adb7e9e2876243b67a59828b3651f4e187781)

cary-ilm commented 5 months ago

Thanks! The website check failure is due to a change in the required version for sphinx, unrelated to this. I'll merge this as soon as I can get that sorted out.

cary-ilm commented 5 months ago

362 should fix the check failure.

josch commented 5 months ago

Hi, thanks a lot for merging my pull request! :smile:

There is a very small curiosity that I just found. The commit in this pull request in commit e79adb7e9e2876243b67a59828b3651f4e187781 lists the following header:

From: Johannes Schauer Marin Rodrigues <josch@mister-muffin.de>

But the commit that landed in the main branch is 7d58bb722faccd21d336cd0de52f611bac00a9c5 which says:

From: josch <josch@mister-muffin.de>

Do you have an idea what happened? Is this some github-specific mangling?

Thank you!

cary-ilm commented 5 months ago

No idea about the commit emails. At first I thought it could have come from the recent introduction of .mailmap, which reconciles duplicate emails, but it doesn't look like you have an entry there.