search

AcademySoftwareFoundation / Imath

Imath is a C++ and python library of 2D and 3D vector, matrix, and math operations for computer graphics
https://imath.readthedocs.io
BSD 3-Clause "New" or "Revised" License
356 stars 104 forks source link

Bring back the EXPORT for PyImath. #397

Closed lamiller0 closed 1 month ago

lamiller0 commented 2 months ago

Address Issue #395 where packages that need to link against PyImath can no longer find it.

lgritz commented 1 month ago

From discussion at the last TSC meeting, we decided that what was really wrong originally that led to the export being removed is that somehow we were installing the module in two places, one of them (incorrectly) in the lib area, instead of strictly in the python site-packages area. THAT is what should be fixed, and if so, then the EXPORT is correct.

Please correct me if my recollection or explanation is wrong, @kdt3rd @meshula @cary-ilm.

We were a little unclear about exactly who should do that fix, and whether we should just go ahead and merge this PR on its own (put the EXPORT back) and separately (but very soon) fix the installation issue, or if we should make a point to do both fixes as one PR.

meshula commented 1 month ago

@lgritz Yes, you're recalling right. We discussed that we should be pointing into site-packages. We didn't solicit a volunteer though.

lgritz commented 1 month ago

Alternate proposal here: https://github.com/AcademySoftwareFoundation/Imath/pull/400