search

AcademySoftwareFoundation / MaterialX

MaterialX is an open standard for the exchange of rich material and look-development content across applications and renderers.
http://www.materialx.org/
Apache License 2.0
1.87k stars 353 forks source link

MaterialXEditor: nodes with multiple outputs only create 1 output for nodes #1220

Closed kwokcb closed 1 year ago

kwokcb commented 1 year ago

This occurs on load and on tab creation. Issues appears to be when creating pins. A single pin is always assumed of type of the node. Nodegraphs seem fine. If the node type is multioutput then an unconnectable output appears to be created.

Appears the fix is to add all active outputs from the nodedef as inputs are added in both these locations: Graph::addNode() and Graph::setUiNodeInfo()

( I can make this change as it seems to do the trick from early testing. e.g. boombox loads in and UsdUvTexture creates okay)

Screen Shot 2023-02-01 at 11 07 29 PM
jstone-lucasfilm commented 1 year ago

That looks really promising, @kwokcb!

jstone-lucasfilm commented 1 year ago

Thanks for both the report and the fix, @kwokcb, and I'll close out this issue.