search

AcademySoftwareFoundation / MaterialX

MaterialX is an open standard for the exchange of rich material and look-development content across applications and renderers.
http://www.materialx.org/
Apache License 2.0
1.88k stars 357 forks source link

Graph Editor: Functional graphs in loaded documents are editable #1223

Open kwokcb opened 1 year ago

kwokcb commented 1 year ago

If a document is loaded and it contains a definition using functional nodegraphs, these graphs show up as being editable. This could cause problems if edited as the instances could no longer work. If you select an instance and look at it's graph, it is also editable.

Query as to what the desired behaviour is here ?

Perhaps make these non-editable (when examining the graph via the instance and also the graph itself) for now to keep things "safe" ?

See this test taken from test suite. The checker definition's nodegraph is editable.

  1. Graph as loaded. Functional graph is show and is editable. editable_functional_graph
  2. Expanding an instance, gives it's nodegraph, which is also editable. image
lfl-eholthouser commented 1 year ago

I agree that these functional nodegraphs should not be editable.