AcademySoftwareFoundation / MaterialX

MaterialX is an open standard for the exchange of rich material and look-development content across applications and renderers.
http://www.materialx.org/
Apache License 2.0
1.88k stars 357 forks source link

Graph Editor: Group nodes to create node graph #2018

Open lfl-eholthouser opened 2 months ago

lfl-eholthouser commented 2 months ago

In order to create a node graph with the MaterialX Graph Editor the user needs to create a node graph node, double click on it to dive into that node and then add nodes inside that node graph node. Nodes that already exist can only be added to a node graph node by copying or cutting and pasting. I think it would be better for the user experience if there was a hot key that would create a node graph node and add all the selected nodes to it.

WaffleBoyTom commented 2 months ago

Hey, this is Thomas, I will be trying to tackle this issue during Dev Days :)

kwokcb commented 2 months ago

Two notes on this:

  1. Nested node graphs are disallowed in the editor currently due to lack of support. You'll want to check that the selected nodes do not include a nodegraph otherwise this will create unsupported nesting.

  2. @lfl-eholthouser, does this also include preserving connections ? I assume to keep it simple it it may not for dev-days , but good to have clarify what the desired logic is here.

lfl-eholthouser commented 2 months ago

@kwokcb I was imagining it would preserve connections That way if someone had created a whole graph at the same level as the surface shader, but then realized they actually wanted it in its own nodegraph that work would not have to be redone. This could be two separate issues as well. If the initial phase is tackled during dev days, a new issue can be creating for adding support for connections in the future.