Closed remia closed 10 months ago
Moving to PySide 6 makes sense anyway, the VFX Reference Platform 2024 is on Qt 6.
as there are still some rough edges and I haven't confirmed if this is due to my changes or just the current development state.
Any specific issues you are seeing?
The committers listed above are authorized under a signed CLA.
Any specific issues you are seeing?
I took a look again today, using this branch (on a Windows workstation though). I realised I broke the pixel probe by adding the imageio support so fixed that in the new commit. I still see an issue with bookmarks switching: when assigning views from different displays (eg. ACES SDR from sRGB and Rec.2100), the switch don't work unless the display you want to switch to is selected in the right panel, hopefully that make sense? Otherwise it seems to work pretty well.
There are some bookmark changes in PR #1845 which may resolve the issue you are seeing. See:
The branch has been generally working for me, I think it would be useful to merge it so that we can move forward. We can fix problems as they come!
This should be ready to merge, sorry about rebasing it may reset the review status of Github unfortunately.
Nice!
This is the branch I shared earlier with some fixes to make it launch on my version of mac OS. I'll leave that in Draft for the time being as there are still some rough edges and I haven't confirmed if this is due to my changes or just the current development state.
To comment on last week TSC discussion, adding a "bookmark" with Ctrl+Number then toggling the current output at the top of the viewer does refresh the image correctly for me.
Note that I originally tried to run it with PySide2 but got stuck with errors like this one and gave up after some time as it seemed easier to just migrate on version 6 which just works out of the box.