Closed SlawekNowy closed 9 months ago
Can confirm
I'm seeing the same error on gentoo with opencolorio 2.3.0 and yaml-cpp. As far as I can see, opencolorio 2.3.0 already includes patch https://github.com/AcademySoftwareFoundation/OpenColorIO/pull/1823 and an additional small patch is needed (cf https://bugs.gentoo.org/914716). Could anybody confirm?
In my case it still proved insufficient. ~Only aliasing the needed target worked.~
EDIT: I likely have found defect in a patch. We should be writing to yaml-cpp_LIBRARY
not yaml-cpp::yaml-cpp_LIBRARY
,
as the former variable is later used to define our target.
Got another error though
CMake Error at share/cmake/modules/Findyaml-cpp.cmake:157 (set_target_properties):
set_target_properties called with incorrect number of arguments.
Call Stack (most recent call first):
share/cmake/macros/ocio_handle_dependency.cmake:114 (find_package)
share/cmake/modules/FindExtPackages.cmake:64 (ocio_handle_dependency)
CMakeLists.txt:449 (include)
Huh. Apparently we need to export includes too as otherwise that set_target_properties would be called with 5 arguments.
Here's the revised patch. yaml-cpp.patch.tar.gz
Thanks for the report and fix @SlawekNowy! Would you mind opening a PR for that if you have the time?
Should be fixed by PR #1891. Please re-open if that's not the case.
The EndeavourOS (flavour of ArchLinux) package of yaml-cpp has no
yaml-cpp
target, onlyyaml-cpp::yaml-cpp
The config file is located and read from properly.