Full fix for broken yaml detection

[SlawekNowy]

Fixes #1858

[linux-foundation-easycla[bot]]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: SlawekNowy (aa4d263c7f435d7ca89d96d70a978cd32ae388e7, f14e3af92f281b89ab28e64b9db9cb1f7283c8a5, ed9b4b753e36b7c583532ec2d3c1e3a45adef0ba, e1a127d078811b4286d0c0430384ca95e21fe10d, c67164ea74fae560354781c191beea1ad9668d2b)

[SlawekNowy]

A better approach would be to switch to yaml-cpp::yaml-cpp in the code and create a backwards compatibility alias in case that target does not exist:

if(TARGET yaml-cpp AND NOT TARGET yaml-cpp::yaml-cpp)
  add_library(yaml-cpp::yaml-cpp ALIAS yaml-cpp)
endif()

Do we really need to break root CMakeLists? Though the bug is still concerning.

[tobim]

Do we really need to break root CMakeLists?

I don't understand what you mean by break? Do you want me to submit another PR?

[SlawekNowy]

I meant that "Does this change break anything using this file?"

[SlawekNowy]

@tobim also what system do you use?

[SlawekNowy]

Ok from beginning. The minimum requirement for yaml-cpp is 0.7.0. Its installed cmake module exports that lib as yaml-cpp. In 0.8.0 this is changed to yaml-cpp::yaml-cpp prompting this very PR. I am afraid that your (@tobim) patch instead of mine would fail builds both on 0.7 and 0.8 version of yaml.

[SlawekNowy]

A better approach would be to switch to yaml-cpp::yaml-cpp in the code and create a backwards compatibility alias in case that target does not exist:

if(TARGET yaml-cpp AND NOT TARGET yaml-cpp::yaml-cpp)
  add_library(yaml-cpp::yaml-cpp ALIAS yaml-cpp)
endif()

Do we really need to break root CMakeLists? Though the bug is still concerning.

That code is already present in the affected file, and yet in some setups it still isn't sufficient.

[remia]

Sorry for adding yet another version but wouldn't it be simpler to make the alias target right after the initial find_package, similar to what we already do for Findexpat.cmake? Did a quick test here, only tested on macOS with 0.8.0 though.

[SlawekNowy]

I theorize that was what @tobim was trying to say, and I agree @remia. Confirmed working on Linux host with yaml-cpp 0.8.0 and Linux chroot with yaml-cpp 0.7.0

[tobim]

Indeed, and that is already implemented in #1891, among some other cleanups.

[remia]

@SlawekNowy Is this PR now superseded by #1891 ? Do you think we should close this one?

[SlawekNowy]

Indeed. Closing in favor of #1891.