Simplify the Findyaml-cpp module

AcademySoftwareFoundation / OpenColorIO

A color management framework for visual effects and animation.

https://opencolorio.org

BSD 3-Clause "New" or "Revised" License

1.74k stars 431 forks source link

Simplify the Findyaml-cpp module #1891

Closed tobim closed 8 months ago

tobim commented 9 months ago

This fixes compatibility with yaml-cpp 0.8, which previously failed because of a get_property call with the wrong target name. I took the liberty to add a few simplifications along the way.

linux-foundation-easycla[bot] commented 9 months ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: tobim (790ca6490359af8ff6f4ba87a2612dbea5434ab1)
:white_check_mark: login: doug-walker / name: Doug Walker (e1f79858d816fe946e570886732bc6b101ad4da6)

doug-walker commented 8 months ago

@tobim , thanks for the contribution. It looks like it is failing the CI on several platforms, could you take a look?

tobim commented 8 months ago

@doug-walker I couldn't figure out what is going wrong on the static workflow jobs locally so I took the liberty add a commit that enables a bit more output. I hope that will point me towards the problem.

tobim commented 8 months ago

@doug-walker can we give it another shot? I hope I got it right this time.

remia commented 8 months ago

Thanks for following up on the questions and the latest updates @tobim!

opoplawski commented 8 months ago

Seems like this should mention that it fixes #1858

doug-walker commented 8 months ago

Thanks to everyone for your work on this issue!