search

AcademySoftwareFoundation / OpenColorIO

A color management framework for visual effects and animation.
https://opencolorio.org
BSD 3-Clause "New" or "Revised" License
1.78k stars 452 forks source link

Add Python 3.12 wheels #1898

Closed remia closed 10 months ago

remia commented 11 months ago

This adds support for Python 3.12 wheels. I'm considering removing Python 3.7 wheel generation given that this version is now EOL and studios relying on it would most likely not get it through PyPI, any thoughts?

JeanChristopheMorinPerso commented 10 months ago

@remia I would recommend continuing to ship wheels for 3.7 for a little while if it doesn't add too much work/annoyances.

remia commented 10 months ago

Sure @JeanChristopheMorinPerso, I don't remember any issues beyond the growing number of Python version we generate wheels for, let's leave it then.

doug-walker commented 10 months ago

Remi, are you expecting the changes in here will fix the Wheel Actions failure?

remia commented 10 months ago

Remi, are you expecting the changes in here will fix the Wheel Actions failure?

Yes, but the rebase against main did bring new errors related to yaml-cpp which need fixing before merging.

remia commented 10 months ago

I believe the issue was that the Python setup.py currently calls CMake configure multiple times (used to get the version of the project) with conflicting OCIO_INSTALL_EXT_PACKAGES flags (no flag to extract the version so defaulting to MISSING then ALL for the actual build). Findyaml-cpp was creating a yaml-cpp::yaml-cpp target even if the package was not found which prevented correct installation of the package during the build.

I also took the liberty to have Installyaml-cpp directly create a yaml-cpp::yaml-cpp target for simplicity.

@tobim are you fine with those changes following your previous PR?

tobim commented 10 months ago

Of course, don't worry about me.

remia commented 10 months ago

I moved the yaml-cpp related fixes to #1907 so this PR should only be merged after it is merged.

remia commented 10 months ago

Ready for merge again now that #1907 was merged (pending review).

KelSolaar commented 10 months ago

Sorry, haven't had time to look at this one like I said I would! Lot of work...