AcademySoftwareFoundation / OpenColorIO

A color management framework for visual effects and animation.
https://opencolorio.org
BSD 3-Clause "New" or "Revised" License
1.78k stars 452 forks source link

Restore GPU workflow and minor updates to CI #1899

Closed remia closed 10 months ago

remia commented 11 months ago

Tentatively restore runs for the GPU workflow which haven't run for the past 3 months now due to wrong filtering settings (I) introduced during a previous update. Also enabled the undefined behaviour sanitizer to the nightly build as it is easy to use alongside address, some unit tests are then removed as these were triggering it (assuming we don't need to test UB).

remia commented 11 months ago

Please ignore the CI failure in Platform latest, it is happening in OpenEXR (using non standard C++ type) and is not related to these changes.

/home/runner/work/OpenColorIO/OpenColorIO/_build/ext/build/openexr/src/openexr_install/src/bin/exrcheck/main.cpp:59:13: error: unknown type name 'uintptr_t'; did you mean 'intptr_t'?

Edit: discussion on OpenEXR Github.

remia commented 10 months ago

New error in the platform-latest Linux / Clang jobs:

/usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/chrono:2320:48: error: call to consteval function 'std::chrono::hh_mm_ss::_S_fractional_width' is not a constant expression
        static constexpr unsigned fractional_width = {_S_fractional_width()};
                                                      ^
/usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/chrono:2320:48: note: undefined function '_S_fractional_width' cannot be used in a constant expression
/usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/chrono:2275:2: note: declared here
        _S_fractional_width()
        ^

Seems like some kind of incompatibility building Clang14 using libstdc++, hopefully this will be solved automatically when runners are updated.

doug-walker commented 10 months ago

Per discussion, merging despite the Platform Latest CI fails.