Proposed fix for pystring include paths

AcademySoftwareFoundation / OpenColorIO

A color management framework for visual effects and animation.

https://opencolorio.org

BSD 3-Clause "New" or "Revised" License

1.74k stars 431 forks source link

Proposed fix for pystring include paths #1900

Closed irieger closed 8 months ago

irieger commented 8 months ago

Make Findpystring.cmake return the full include directory to pystring so that prefixing includes with "pystring/" is no longer required.

This changes the behaviour of the included Findpystring.cmake to match the bahaviour of other regular find_package modules to report the full include directory removing the requirement to use "pystring/" when including "pystring.h" etc. (This follows from https://github.com/conan-io/conan-center-index/pull/20703#discussion_r1383018774)

linux-foundation-easycla[bot] commented 8 months ago

:x: - login: @irieger / name: Ingmar Rieger . The commit (79c8a471024aeb125fb1bd3a368e9a8a6db65704) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

remia commented 8 months ago

Thanks @irieger, FYI there was a related discussion today in #1897, here is a similar commit I did earlier.

irieger commented 8 months ago

Good to see. Will close this and comment with some feedback on your Pull request.

irieger commented 8 months ago

Added a comment to https://github.com/remia/OpenColorIO/pull/52 as the current state wouldn't build on Arch Linux but otherwise it contains the changes as proposed here.

remia commented 8 months ago

Hi @irieger,

I don't see your comment, can you double check you published it? Thanks for looking into it.

irieger commented 8 months ago

New to those github workflows. Just sent the review. Hadn't realised I need to push another button. Gitlab which is my day to day tool has a much more prominent submit button ...