ocioview image and PySide6 updates

AcademySoftwareFoundation / OpenColorIO

A color management framework for visual effects and animation.

https://opencolorio.org

BSD 3-Clause "New" or "Revised" License

1.74k stars 431 forks source link

ocioview image and PySide6 updates #1912

Closed michdolan closed 3 months ago

michdolan commented 8 months ago

This PR makes the following changes to ocioview:

Image viewer operates on RGB instead of RGBA, with an assumed opaque alpha
Image viewer pan and zoom regression fixed following change from imath to NumPy for transform implementation
Image read implementations moved to utility module
NumPy array used for image data messages instead of oiio ImageBuf
UI size adjustments to account for Qt6 style changes
Pyide6 compatibility fixes

doug-walker commented 5 months ago

@michdolan , should we go ahead and merge this?

michdolan commented 3 months ago

@remia thoughts on the CI failure I'm getting since updating the base? It's related to CMake, but this work only changed Python files internal to ocioview. Safe to ignore?

remia commented 3 months ago

@remia thoughts on the CI failure I'm getting since updating the base? It's related to CMake, but this work only changed Python files internal to ocioview. Safe to ignore?

I haven't time to investigate properly this week but it seems like the issue we have in https://github.com/AcademySoftwareFoundation/OpenColorIO/issues/1964 ? I didn't see the error as the job was in canceled state today, I relaunched it and it now passes so this might have been fixed with a CMake update.