search

AcademySoftwareFoundation / OpenColorIO

A color management framework for visual effects and animation.
https://opencolorio.org
BSD 3-Clause "New" or "Revised" License
1.74k stars 430 forks source link

Built-In Transform support for Apple Log #1941

Closed JGoldstone closed 5 months ago

JGoldstone commented 5 months ago

Address request for Apple Log support as raised in #1916

JGoldstone commented 5 months ago

Thanks, both of you, for the speedy review. Not having write access myself, could I ask one of you to merge the request and close this out?

carolalynn commented 5 months ago

Let’s wait for Robert to take a look, please. I’ve let him know it’s up.

KelSolaar commented 5 months ago

This would be a good PR to add as a developer guide example, i.e., how to add a new transformation.

JGoldstone commented 5 months ago

To Thomas' point, yes, including the introspective aspects, i.e. not allowing the new builtins to be used in pre-3.4 configs, and being the first thing in a release to have such a constraint.

rkmolholm commented 5 months ago

Looks good to me - thank you Joseph!

doug-walker commented 4 months ago

@rkmolholm , after looking at the results, I'm not sure this transform is correct. It may simply be that the footage I have was not correctly captured. Could you point us at some known good test material in Apple Log space?