Closed remia closed 3 months ago
My only comment is whether we should include the GIL release in this PR? https://github.com/AcademySoftwareFoundation/OpenColorIO/pull/1945/files#diff-6c87f76bfb1f06a48bb762f97632eee604f4d8cd2e852347c3b46209a056086a
Those seems to be beyond pure CI workflow changes.
If people are happy with it then fine.
@KelSolaar, given the large delays in getting PRs merged, we all sometimes include small miscellaneous improvements into a larger PR. It's not ideal, but it's a response to the current state of affairs where we don't have a sufficient number of reviewers.
@doug-walker : All good with me and I understand the frustration! It is one of the reason I have been hesitant to move colour
to the ASWF and a more formal review process, it certainly hinders the development velocity.
Merging for good measure because the aforementioned note was the only comment I had! Thanks @remia.
@doug-walker : All good with me and I understand the frustration! It is one of the reason I have been hesitant to move
colour
to the ASWF and a more formal review process, it certainly hinders the development velocity.
Such rules are made by every project TSC individually to pick the right set of procedures for their project and team. There is no ASWF-mandated policy on how reviews and merges work.
I'm sorry, I see I was tagged here, but I didn't notice this PR until today. Apologies if you wanted me to look at something here and I failed to reply. (I do "watch" this project, but sometimes when I'm busy, I'm a little eager with the delete key if I don't see a PR title that I think is highly relevant to me.)
@KelSolaar Agree the GIL changes could have been separated in a different PR, I included these here because it fixed the WIndows Platform Latest workflow when I switched them to C++23.
@lgritz No worry at all! I tagged you because I made some OSL related fix for the unit tests.
This PR attempt to fix various issues on the GHA workflows:
Update the CI on Linux to add VFX 2024 Reference Platform new containers (thanks @jfpanisset), there is currently an issue with OIIO's Ptex dependency which might need a fix in the OCIO Docker image.Revert this change, will wait for the next ASWF Docker release.