search

AcademySoftwareFoundation / OpenColorIO

A color management framework for visual effects and animation.
https://opencolorio.org
BSD 3-Clause "New" or "Revised" License
1.74k stars 430 forks source link

Fix CPU unit test failures on recent macOS ARM platforms #1948

Closed markreidvfx closed 4 months ago

markreidvfx commented 4 months ago

Fixes the macOS ARM CPU unit tests for https://github.com/AcademySoftwareFoundation/OpenColorIO/issues/1946.

For the string comparison failures I add a utility function called StringFloatVecClose that converts the string values to float and compares with a threshold.

There is still a metal unit test failure happening on my machine, haven't looked into the cause of it.

doug-walker commented 4 months ago

Thank you Mark! By the way, if the branch name contains "macarm" it will run the macARM CI Action.

JeanChristopheMorinPerso commented 4 months ago

@doug-walker FYI, GitHub now provides arm runners for free for OSS projects. See https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/.

doug-walker commented 4 months ago

Yes, thank you @JeanChristopheMorinPerso! I've been watching OIIO's journey on macARM and saw the CI WG notes as well. But no one has had time yet to update OCIO's Actions to use it. I just wanted to make sure Mark was aware that we do currently have a paid Action he could use to test his work, if it's helpful.

markreidvfx commented 4 months ago

I tried renaming my branch and it automatically closed this, I'll open an new PR