minizip seems to be changing to a hex number for MZ_VERSION_BUILD

AcademySoftwareFoundation / OpenColorIO

A color management framework for visual effects and animation.

https://opencolorio.org

BSD 3-Clause "New" or "Revised" License

1.74k stars 430 forks source link

minizip seems to be changing to a hex number for MZ_VERSION_BUILD #1954

Open opoplawski opened 4 months ago

opoplawski commented 4 months ago

This hasn't been released yet but:

https://github.com/zlib-ng/minizip-ng/commit/a7d612adf210353ba0391e20d1d1abbb72d1ad83 https://github.com/zlib-ng/minizip-ng/issues/758

linux-foundation-easycla[bot] commented 4 months ago

:white_check_mark:login: opoplawski / (d7a0c1a15feee6dfd7f34d3b921fee9f8d370252)

The committers listed above are authorized under a signed CLA.

markreidvfx commented 3 months ago

I think we should parse MZ_VERSION instead too. MZ_VERSION_BUILD will be too unreliable going forward.

markreidvfx commented 3 months ago

The cmake module that detects minizip does parse the MZ_VERSION from mz.h as minizip-ng_VERSION. So it should be just a matter of extracting the major version and creating a macro definition for it.