AcademySoftwareFoundation / OpenColorIO

A color management framework for visual effects and animation.
https://opencolorio.org
BSD 3-Clause "New" or "Revised" License
1.74k stars 430 forks source link

Fix linking when building fully shared with the dependencies also build as shared libraries #1958

Closed irieger closed 1 month ago

irieger commented 3 months ago

I'd suggest to fix the linking to ensure OpenColorIO can be build with its own requirements build as shared libraries. Currently it will throw linker errors when linking all the included CLI tools.

For more details, also see: https://github.com/conan-io/conan-center-index/pull/23112

Up to now the conan recipe didn't run with dynamic linking as there was a blocker in the configuration to link minizip-ng dynamically. When I tried to fix it locally, I came up with this change. Otherwise it can also be done by fixing the linking of all the tools to include the requirements manually.

linux-foundation-easycla[bot] commented 3 months ago

CLA Not Signed

remia commented 1 month ago

Linking the related Conan issue for reference: https://github.com/conan-io/conan-center-index/issues/23421, this seems to be a ld specific issue according to this comment.

irieger commented 1 month ago

Linking the related Conan issue for reference: conan-io/conan-center-index#23421, this seems to be a ld specific issue according to this comment.

Sorry, forgot to update here. Good to have it linkes here but maybe it is a non-issue here and we just close it? As it isn't OCIO specific as it happens for other things too, but depends on the linker it might be more a linker/build infra problem then. Or would you object closing?

remia commented 1 month ago

Yes I'll close this then, I think the issue is more likely to be with Conan, in the event anything needs to be changed in OCIO CMake scripts, we can obviously open a new PR.