AcademySoftwareFoundation / OpenColorIO

A color management framework for visual effects and animation.
https://opencolorio.org
BSD 3-Clause "New" or "Revised" License
1.8k stars 456 forks source link

Python 3.13 wheels #2052

Closed remia closed 2 months ago

remia commented 2 months ago

Here is a list of changes included:

Tagging @KelSolaar

KelSolaar commented 2 months ago

LGTM besides the classifier.

remia commented 2 months ago

Nice work! Really strange, that the OCIO_PYTHON_LOAD_DLLS_FROM_PATH thing is causing problems. That's pretty baffling.

Do we want to support free-threaded mode too for Python 3.13?

For the segfault, let's continue the discussion in https://github.com/AcademySoftwareFoundation/OpenColorIO/issues/2040!

I don't think we have the resources to add support for GIL-free Python in the coming release and not exactly sure yet what work will be required to be honest. From a quick look, I assume we have to upgrade to pybind 2.13 and start using py::mod_gil_not_used() to check whether we need to handle unlocking / locking the GIL or not?