AcademySoftwareFoundation / OpenColorIO

A color management framework for visual effects and animation.
https://opencolorio.org
BSD 3-Clause "New" or "Revised" License
1.79k stars 455 forks source link

Update usage_examples.rst #2062

Closed shaneantrim closed 1 month ago

shaneantrim commented 1 month ago

Changed Displaying an image, using the GPU (Full Viewport Pipeline) to Displaying an image, using the CPU (Full Viewport Pipeline) Added Python example under Displaying an image, using the CPU (Full Viewport Pipeline) Added Displaying an image, using the GPU comment section.

linux-foundation-easycla[bot] commented 1 month ago

CLA Signed

The committers listed above are authorized under a signed CLA.

carolalynn commented 1 month ago

Hi @shaneantrim, thanks for this! In general it looks good, but we required signed commits (git commit -s). To fix this since you've already committed it:

git commit --amend -s
git push <your_remote_fork_name> <your_branch_name> --force
shaneantrim commented 1 month ago

My commit has been updated and signed off on.

KelSolaar commented 1 month ago

@doug-walker : I was wondering, do we want the C++ and Python match a bit more in what they actually implement so that it is possible to compare the difference between languages? I think that would be useful for users and maybe show that C++ is not "scary".

KelSolaar commented 1 month ago

Put another way, do we want the C++ and Python examples to match almost exactly?

doug-walker commented 1 month ago

@KelSolaar , yes, ideally the C++ and Python should match, and that is the case for the other examples on this page where both languages are present. Shane is adding a new Python example (based on the old documentation but with the new API), since he is a Python dev. Ideally at some point a C++ dev could add the corresponding code.