AcademySoftwareFoundation / OpenColorIO

A color management framework for visual effects and animation.
https://opencolorio.org
BSD 3-Clause "New" or "Revised" License
1.76k stars 438 forks source link

OpenColorIO 1.1.0 fails to build from source on Debian unstable/sid #506

Closed mfvescovi closed 6 years ago

mfvescovi commented 6 years ago

Hi!

While test building latest release on Debian unstable/sid, OCIO fails due to:

[ 37%] Building CXX object src/core/CMakeFiles/OpenColorIO.dir/NoOps.cpp.o cd "/<>/debian/cmake/src/core" && /usr/bin/c++ -DOpenColorIO_EXPORTS -I"/<>/export" -I"/<>/debian/cmake/export" -I"/<>/ext/oiio/src/include" -I"/<>/debian/cmake/ext/dist/include" -g -O2 -fdebug-prefix-map=/<>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wshadow -Wconversion -Wcast-qual -Wformat=2 -fPIC -DTIXML_USE_STL -fPIC -fvisibility=hidden -Werror -o CMakeFiles/OpenColorIO.dir/NoOps.cpp.o -c "/<>/src/core/NoOps.cpp" /<>/src/core/MathUtils.cpp:333:10: error: 'void OpenColorIO::v1::{anonymous}::GetMxbResult(float, float, float, float)' defined but not used [-Werror=unused-function] void GetMxbResult(float vout, float m, float x, float v) ^~~~

Attached opencolorio_1.1.0~dfsg0-1_buildlog is the full log.

Thanks.

dracwyrm commented 6 years ago

Have you tried this patch? https://github.com/imageworks/OpenColorIO/commit/f39552d70098a98f7c1fb3b4f020b550ce2dd75a.patch It's in the master branch. There are a few other patches that you may want to look at as well. :)

mfvescovi commented 6 years ago

It's in the master branch. There are a few other patches that you may want to look at as well. :)

Then, probably, a v1.1.1 is on its way, given 1.1.0 fails to build... right? ;-) I'm not going to cherry-pick commits randomly to get OCIO build again on Debian. :-P

dracwyrm commented 6 years ago

You only need that patch to make it build. I included it in the Gentoo ebuild, but with 1.1.1, I'll be able to clean up the files to remove those patches.

mfvescovi commented 6 years ago

OK, I've added that patch and OCIO 1.1.0 builds fine now. Thanks @dracwyrm. Closing.