AcademySoftwareFoundation / OpenCue

A render management system you can deploy for visual effects and animation productions.
https://www.opencue.io
Apache License 2.0
832 stars 202 forks source link

Add prometheus metrics collecting #1408

Closed DiegoTavares closed 4 months ago

DiegoTavares commented 4 months ago

Adds a new optional module that runs every 60 seconds to collect metrics about the state of thread pools. Also, it collects basic time measurements and counts from dispatchDaoJdbc, which helps assess performance degradation on the system.

Metrics are exposed under /metrics for being collected by a Prometheus instance (the Prometheus server setup is not part of this PR).

A future PR is coming that will include Grafana charts to consume the exposed metrics.

Exposed metrics:

BookingQueue

Manage Queue

DispatchQueue

HostReportQueue

General Performance Metrics:

DiegoTavares commented 4 months ago

(In reply to Jimmy Christensen's question that seem to have vanished from the PR)

Looking from the application perspective, the module is collecting metrics from the threadpools and exporting them to prometheus.

So for prometheus it is an exporter, for opencue it is a collector!? I confess I was having problems with the terminology, I'll gladly change if you think it is confusing the way it is now.


Diego Tavares da Silva @. @.

On Wed, Jul 10, 2024 at 11:58 PM Jimmy Christensen @.***> wrote:

Not to go too much into semantics here, but isn't this more of an exporter and not a collector?

— Reply to this email directly, view it on GitHub https://github.com/AcademySoftwareFoundation/OpenCue/pull/1408#issuecomment-2222179147, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGXQ24VM6FBZONPCTLZTXTZLYUIRAVCNFSM6AAAAABKV4IC36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRSGE3TSMJUG4 . You are receiving this because you authored the thread.Message ID: @.***>

lithorus commented 4 months ago

I removed it after I checked up on it. You're absolutely correct 🙂 Just ignore it 😅 But great to see Prometheus support as a priority!

DiegoTavares commented 4 months ago

@bcipriano FYI