Fix RQD log parsing for stdout and stderr consumption

AcademySoftwareFoundation / OpenCue

A render management system you can deploy for visual effects and animation productions.

https://www.opencue.io

Apache License 2.0

832 stars 202 forks source link

Fix RQD log parsing for stdout and stderr consumption #1427

Closed ramonfigueiredo closed 3 months ago

ramonfigueiredo commented 4 months ago

Fix RQD log parsing to handle non-ASCII characters without timestamp for stdout and stderr consumption

Implemented simultaneous consumption of stdout and stderr.
Ensured log monitoring for running jobs.
Addressed delays and potential loss of stderr content.
Used select module for concurrent stream monitoring.
Enhanced reliability of log outputs in case of job failures.

ramonfigueiredo commented 4 months ago

DiegoTavares commented 3 months ago

@ramonfigueiredo I remember you mentioned this PR should be ready for review. Can you remove the Draft flag and resolve the conflicts?

ramonfigueiredo commented 3 months ago

@ramonfigueiredo I remember you mentioned this PR should be ready for review. Can you remove the Draft flag and resolve the conflicts?

Hi @DiegoTavares This is ready for review. Thanks!

DiegoTavares commented 3 months ago

Looks good to me. This work on this PR overlaps with the work done on #1429, which is also mature enough to be merged. Let's discuss on the next TSC how we can get both branches combined to avoid conflicts.

ramonfigueiredo commented 3 months ago

Looks good to me. This work on this PR overlaps with the work done on #1429, which is also mature enough to be merged. Let's discuss on the next TSC how we can get both branches combined to avoid conflicts.

Let's merge the code from @lithorus https://github.com/AcademySoftwareFoundation/OpenCue/pull/1429 instead of mine. Let's talk more about this in the TSC meeting.