AcademySoftwareFoundation / OpenCue

A render management system you can deploy for visual effects and animation productions.
https://www.opencue.io
Apache License 2.0
832 stars 202 forks source link

[cuegui] Remove constants test that is not testing constants #1505

Closed DiegoTavares closed 2 months ago

DiegoTavares commented 2 months ago

Remove the unit test test__should_use_default_values which is a recipe for problems when deploying cuegui. The test was supposed to confirm constants defaults are set properly, but the current implementation applies values from cuegui.yaml, which is supposed to be configured by users to match their local requirements. With this, running the unit test locally after configuring cuegui.yaml will always fail.

The test itself didn't accomplish much, so I suggest removing it altogether.

ramonfigueiredo commented 2 months ago

FYI @bcipriano