AcademySoftwareFoundation / OpenCue

A render management system you can deploy for visual effects and animation productions.
https://www.opencue.io
Apache License 2.0
832 stars 202 forks source link

[cuegui] Kill a Job from Windows. #1520

Closed KernAttila closed 1 month ago

KernAttila commented 1 month ago

Link the Issue(s) this Pull Request is related to. Fixes: https://github.com/AcademySoftwareFoundation/OpenCue/issues/1519

Summarize your change. Use platform.uname() instead of os.uname(). They have the same result on Linux, but os.uname() is not available on Windows, making us unable to kill a job from this OS.

Additional information. Linux (ubuntu 22.04.6):

>>> os.uname()
posix.uname_result(sysname='Linux', nodename='titan', release='6.8.0-45-generic', version='#45~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Wed Sep 11 15:25:05 UTC 2', machine='x86_64')
>>>platform.uname()
uname_result(system='Linux', node='titan', release='6.8.0-45-generic', version='#45~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Wed Sep 11 15:25:05 UTC 2', machine='x86_64')

Windows (11):

>>> platform.uname()
uname_result(system='Windows', node='StarChaser', release='10', version='10.0.22631', machine='AMD64')