AcademySoftwareFoundation / OpenCue

A render management system you can deploy for visual effects and animation productions.
https://www.opencue.io
Apache License 2.0
832 stars 202 forks source link

[rqd] Host defined facility in rqd.conf sets to local by default #1521

Open stevenparkerco3 opened 1 month ago

stevenparkerco3 commented 1 month ago

Describe the bug While rqd.conf supports the DEFAULT_FACILITY tag, if rqd attempts to connect to a cuebot with a DEFAULT_FACILITY that is not defined on the cuebot host, it defaults to local. This was unexpected, and perhaps wrong?

Cuebot and RQD should be more aggressively denying host attachments to opencue if it's attempting to use a facility that isn't yet defined or know in cuebot with some active (and specific) error message at the startup of rqd.

Steps to Reproduce in rqd.conf:

DEFAULT_FACILITY=aws-uswest2
RQD_TAGS=util

Then start rqd to any cuebot server which does not define this facility. It will attach (silently) to local.util.

Expected behavior rqd should return an error once cuebot decides that the facility name isn't known to that cuebot installation. This error should include some general directions on how to add a facility and allocations to the cuebot server.

Version Number master

stevenparkerco3 commented 1 month ago

Offending section seems to be from here:

https://github.com/AcademySoftwareFoundation/OpenCue/blob/7e9ae6c20b951632a51ff490a336718647139cee/cuebot/src/main/java/com/imageworks/spcue/service/HostManagerService.java#L174