AcademySoftwareFoundation / OpenCue

A render management system you can deploy for visual effects and animation productions.
https://www.opencue.io
Apache License 2.0
832 stars 202 forks source link

View in OpenRV functionality locks up any OpenCue GUI parent elements. #1568

Closed TxRxFx closed 1 week ago

TxRxFx commented 2 weeks ago

Describe the bug View in OpenRV functionality locks up any OpenCue GUI parent elements to the point where you can't close OpenRV or Cue GUI elements.

To Reproduce Steps to reproduce the behavior:

  1. Right click on a task with output defined
  2. Select "View in OpenRV"
  3. If output format is presented to OpenRC correctly and it's available it'll open but lock up Cue GUI elements till it's closed
  4. If it's missing I often get scenario where OpenRV's window or console reporting it's not reachable as locked out and need to kill the processes

Expected behavior Simply open expected output in OpenRV

Version Number 1.0.0 release (5.0.0 internal version)

Additional context Using Ubuntu 20.04, Rez and exrs output added to farm tasks formatted to end in @@@@@@.exr

ramonfigueiredo commented 2 weeks ago

Hi @lithorus , can you test and validate this on OpenRV?

It is working fine on the itView (SPI) side.

lithorus commented 2 weeks ago

I did test it (in the same environment as above). Perhaps you fork the itview process?

Will test tomorrow in a little more vanilla setup.

lithorus commented 2 weeks ago

It's using subprocess.check_call which explains why it locks the UI

ramonfigueiredo commented 2 weeks ago

I did test it (in the same environment as above). Perhaps you fork the itview process?

Will test tomorrow in a little more vanilla setup.

@lithorus Thanks for testing this and fixing it for the OpenRV and RV side. It's better to change the code to use POpen. I will test on the itView (SPI) side after you submit the new PR.

DiegoTavares commented 2 weeks ago

A fix is coming soon for this issue

ramonfigueiredo commented 1 week ago

Fixed by @lithorus

PR: https://github.com/AcademySoftwareFoundation/OpenCue/pull/1576