AcademySoftwareFoundation / OpenCue

A render management system you can deploy for visual effects and animation productions.
https://www.opencue.io
Apache License 2.0
832 stars 202 forks source link

[cuebot] Cuebot unable to dispatch frames #1572

Closed lithorus closed 2 weeks ago

lithorus commented 2 weeks ago

Describe the bug It seems like the recent changes broke job dispatching from cuebot

It errors out with :

2024-11-05 23:08:55.764  INFO 32971 --- [pool-1-thread-1] c.i.spcue.util.CueExceptionUtil          : Caught unexpected exception caused by: java.lang.NullPointerException
2024-11-05 23:08:55.764  INFO 32971 --- [pool-1-thread-1] c.i.spcue.util.CueExceptionUtil          : StackTrace: 
java.lang.NullPointerException
    at com.imageworks.spcue.dispatcher.commands.DispatchBookHost$1.wrapDispatchCommand(DispatchBookHost.java:90)
    at com.imageworks.spcue.dispatcher.commands.DispatchCommandTemplate.execute(DispatchCommandTemplate.java:36)
    at com.imageworks.spcue.dispatcher.commands.DispatchBookHost.run(DispatchBookHost.java:114)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
    at java.base/java.lang.Thread.run(Thread.java:829)

To Reproduce Steps to reproduce the behavior:

  1. Start cuebot
  2. Start rqd using the cuebot
  3. cuebot will spit out errors instead of running any frames

Expected behavior That frames are dispatched by cuebot

Version Number 3341bcb856306c6cbd500ada6ce5f6f6a40faa37

DiegoTavares commented 2 weeks ago

Please take a look at https://github.com/AcademySoftwareFoundation/OpenCue/pull/1570 New opencue.properties are required now for dispatcher.memory attributes

DiegoTavares commented 2 weeks ago

To be more specific: https://github.com/AcademySoftwareFoundation/OpenCue/pull/1570/files#diff-56a889267cecda9142cbd15fadf5eaf4becb1530db832f946d6a6ce0a45f6027

lithorus commented 2 weeks ago

But they are not part of the default config?

DiegoTavares commented 2 weeks ago

Yes, all new properties were added to the default config: https://github.com/AcademySoftwareFoundation/OpenCue/blob/master/cuebot/src/main/resources/opencue.properties#L162

lithorus commented 2 weeks ago

I'm also using the default config and I get the error as above. It's the master branch with no local changes.

DiegoTavares commented 2 weeks ago

Let me double check on my end

DiegoTavares commented 2 weeks ago

Ohh, it might be the autowiring that's causing a nullpointException. I've reverting the last commit to master