search

AcademySoftwareFoundation / OpenCue

A render management system you can deploy for visual effects and animation productions.
https://www.opencue.io
Apache License 2.0
832 stars 202 forks source link

Draft: [rqd/pyoutline/pycue] Fix Dockerfile build failures #1583

Closed n-jay closed 6 days ago

n-jay commented 1 week ago

Link the Issue(s) this Pull Request is related to. https://github.com/AcademySoftwareFoundation/OpenCue/issues/1582

Summarize your change. Fix missing file error by running a COPY command to import file into the images during build.

DiegoTavares commented 6 days ago

Both #1584 and #1583 are approved and try to solve the same thing. #1584 seems more complete, would you mind being added as a co-author on it @n-jay ?

n-jay commented 6 days ago

That's fine @DiegoTavares, However, its just that I mentioned to @lithorus that I was actually working on the fix and simply wanted to verify if the issue was present. I felt its somewhat bad practice to proceed with a separate fix that does the same thing when one has already pushed.

Further I believe there's a problem on https://github.com/AcademySoftwareFoundation/OpenCue/pull/1584 in the COPY command because the ci directory doesn't seem to get detected by the docker build context for some reason: image

I wanted to check this with you guys before proceeding to make the same change on the rest of the Dockerfiles, hence why https://github.com/AcademySoftwareFoundation/OpenCue/pull/1583 was left incomplete.

lithorus commented 6 days ago

I didn't see your message before I had submitted the PR.

Regarding the copy, I found out why and messaged you about it.

n-jay commented 6 days ago

Water under the bridge I did mention that I was working on a fix multiple times, however, and would've really appreciated some feedback. image