search

AcademySoftwareFoundation / OpenCue

A render management system you can deploy for visual effects and animation productions.
https://www.opencue.io
Apache License 2.0
815 stars 193 forks source link

Blank suggestions in CueSubmit #275

Closed sharifsalah closed 4 years ago

sharifsalah commented 5 years ago

On macOS 10.14.4, there's a white empty box that appears under most form fields in CueSubmit. It looks like CueSubmit is trying to suggest previously filled in values but as the box is white the suggestion isn't actually visible:

Screen Shot 2019-04-11 at 1 58 14 PM
bcipriano commented 5 years ago

@gregdenton Are you able to reproduce this? I can't - with no previous suggestions I don't get any white box and when there are suggestions they're clearly visible.

gregdenton commented 5 years ago

@sharifsalah Just to confirm, do you happen to know when you pulled the cuesubmit code? I feel like I remember this being an issue before, but I thought it was fixed.

sharifsalah commented 5 years ago

This was with the latest v0.2.0 release. I ran through the install for the first time on this particular machine with this version.

I'll keep an eye out for this on other machines I run through the installation on.

gregdenton commented 5 years ago

Thanks Sharif. I'll take a look and track it down.

bcipriano commented 4 years ago

I still see this from time to time. Not sure exactly what needs to happen to reproduce it.

shiva-kannan commented 4 years ago

Hey all! I'll be applying to ASWF for GSoC and I thought this could be a good first issue.

The second time I ran cuesubmit I was able to see this (I'm on a Mac) :

Screen Shot 2020-03-10 at 10 40 33 PM

It seems like the issue is with the popup of the completer having a white background. I went ahead and assigned a style with a background color to the popup listview and this is how it looks now :

Screen Shot 2020-03-11 at 11 15 07 AM

@bcipriano could you elaborate on when it has worked for you? I assumed since the background and text were both white, it shouldn't have worked at all before.

Let me know what you guys think!

bcipriano commented 4 years ago

@shiva-kannan That's great! I've assigned this issue to you so please feel free to send your fix as a PR :)

@bcipriano could you elaborate on when it has worked for you? I assumed since the background and text were both white, it shouldn't have worked at all before.

I don't believe this has worked for me at all recently. I seem to remember in the past having seen a white background with black text, but if we're not setting style information it must be relying on my OS to determine some of the colors. Possibly it was before I switched to using Dark Mode all the time? I'm not sure but your suggested fix sounds like the right way forward here.