Closed kwizart closed 2 years ago
Do you happen to know which preprocessor symbols I can use to distinguish between armv7 vs aarch64?
I think it's __aarch64__
I will make a patch.
Proposed fix in #3361. I don't have a way to test this directly. @kwizart can you try that patch on your end to verify?
Thanks, testing in progress. Hopefully I will report in the next hours.
Seems like the build is failing with -fpu=neon on armv7hl, other issue arise: https://kojipkgs.fedoraproject.org//work/tasks/7125/83647125/build.log
Yes, thanks for the help, the logs make it apparent that there are a couple additional instructions we were using that are only available on aarch64, not all NEON. I've updated the patch with some additional fixes.
@kwizart Did you have a chance to test the latest attempt in #3361? Does that complete the job of fixing this issue?
Describe the bug When building a dependency with armv7 neon enabled (-fpu=neon), oiio fail with the following error:
To Reproduce Steps to reproduce the behavior:
Expected behavior Build should succeed, but fails because vaddvq_s32 is only available on aarch64 and not on armv7. Most of the time armv7 (distro/)users don't explicitly enable neon.
Evidence vaddvq_s32 is tagged as aarch64 only in this documentation. https://arm-software.github.io/acle/neon_intrinsics/advsimd.html
Platform information: