Closed touraill-adobe closed 1 month ago
Hi, before we merge, we need a CLA on file from you, and also the commit needs to be "signed" to indicate acceptance of the required DCO. You can do the latter simply by
git commit --amend -s
git push origin <branchname> --force
Hi, before we merge, we need a CLA on file from you, and also the commit needs to be "signed" to indicate acceptance of the required DCO. You can do the latter simply by
git commit --amend -s git push origin <branchname> --force
Yes I'm waiting for the CLA to be signed by my company :)
Sorry about the missing sign-off, I missed the requirement when reading the guidelines, I updated the commit.
Sorry, I didn't notice that the CLA had been fixed up here. Merging.
When building OIIO as a subdirectory of a super-project (with
add_subdirectory
), it is better to honor the output directories specified by the parent project.In our project, it was causing issues because OIIO libs were ending in a different folder from USD plugins, which thereby failed to load correctly in the build tree.