AcademySoftwareFoundation / OpenImageIO

Reading, writing, and processing images in a wide variety of file formats, using a format-agnostic API, aimed at VFX applications.
https://openimageio.readthedocs.org
Apache License 2.0
1.98k stars 597 forks source link

build: Don't change CMAKE_XXX_OUTPUT_DIRECTORY when built as subdir #4417

Closed touraill-adobe closed 1 month ago

touraill-adobe commented 2 months ago

When building OIIO as a subdirectory of a super-project (with add_subdirectory), it is better to honor the output directories specified by the parent project.

In our project, it was causing issues because OIIO libs were ending in a different folder from USD plugins, which thereby failed to load correctly in the build tree.

linux-foundation-easycla[bot] commented 2 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

lgritz commented 2 months ago

Hi, before we merge, we need a CLA on file from you, and also the commit needs to be "signed" to indicate acceptance of the required DCO. You can do the latter simply by

git commit --amend -s
git push origin <branchname> --force
touraill-adobe commented 2 months ago

Hi, before we merge, we need a CLA on file from you, and also the commit needs to be "signed" to indicate acceptance of the required DCO. You can do the latter simply by

git commit --amend -s
git push origin <branchname> --force

Yes I'm waiting for the CLA to be signed by my company :)

Sorry about the missing sign-off, I missed the requirement when reading the guidelines, I updated the commit.

lgritz commented 1 month ago

Sorry, I didn't notice that the CLA had been fixed up here. Merging.