search

AcademySoftwareFoundation / OpenPBR

Specification and reference implementation for the OpenPBR Surface shading model
Apache License 2.0
425 stars 18 forks source link

Ordering of the parameters #104

Closed virtualzavie closed 11 months ago

virtualzavie commented 11 months ago

The parameters should be sorted logically, and be ordered in a manner that is consistent with the workflow of the artist.

In a few places, the currently proposed ordering of the parameters seem to go against the grain.

Anisotropy

The currently proposed list includes:

Identifier Label
specular_roughness Roughness
specular_ior IOR
specular_ior_level IOR level
specular_anisotropy Anisotropy
specular_rotation Rotation

and:

Identifier Label
coat_roughness Roughness
coat_ior IOR
coat_ior_level IOR level
coat_anisotropy Anisotropy
coat_rotation Rotation

However, the artist will typically work with roughness and anisotropy at the same time. Having IoR in between makes it less practical.

I suggest changing the order to: Identifier Label
specular_roughness Roughness
specular_anisotropy Anisotropy
specular_rotation Rotation
specular_ior IOR
specular_ior_level IOR level

And likewise for coat.

jstone-lucasfilm commented 11 months ago

This has been addressed in #105, thanks @virtualzavie!