AcademySoftwareFoundation / OpenPBR

Specification and reference implementation for the OpenPBR Surface shading model
Apache License 2.0
425 stars 18 forks source link

Refactor text according to physical ground truth policy #115

Closed portsmouth closed 11 months ago

portsmouth commented 11 months ago

This modifies the text and stated model to try to be consistent about having the model define an as-specific-as-possible concrete physical material model with known BSDFS, which determines a well-defined ground truth.

This is stated in the introduction section as:

Unlike previous models such as Autodesk Standard Surface [Georgiev2019], we define the model by describing the physical structure as unambiguously as possible, rather than by specifying a particular form of implementation. At the level of computer graphics, the model is completely physically specified if the BSDF (Bidirectional Scattering Distribution Function) of each slab interface, and the volumetric properties of each slab medium, are specified. The ground truth appearance of the model is then defined to be given by the BSDF obtained by physical light transport through the whole structure of component slabs. Implementations thus have an unambiguous goal appearance which they can reason about and approximate logically, to a greater or lesser degree of fidelity, on the basis of physics and light transport. The closer an implementation is to reproducing this ground truth physical appearance, the better it conforms to the specification.

Specific changes are:

Complete conformance to the spec is defined as reproducing all the physical inter-layer light transport effects, though this is not typically practical. In practice, each implementation must decide what level of approximation to use for the light transport within layers, trading off accuracy for efficiency according to its own particular use case.

virtualzavie commented 11 months ago

Let's try to merge it, lower priority than some other changes.