AcademySoftwareFoundation / OpenPBR

Specification and reference implementation for the OpenPBR Surface shading model
Apache License 2.0
459 stars 18 forks source link

State white-furnace test behavior #146

Closed portsmouth closed 4 months ago

portsmouth commented 10 months ago

The model as described should pass a "white-furnace" test, in various configurations. This is because the model itself describes a physical structure (not a particular approximation) where the ground truth appearance is supposed to be the correct physical light transport through the structure thus defined.

So the ground truth appearance should perfectly preserve energy, assuming the parameters are configured so there is no physical energy dissipation/absorption. Configurations where this should happen, so a white-furnace test (i.e. test that the object should disappear when illuminated by uniform background light) would pass include:

It would be good to point this out in the spec, as these are obviously important unit test cases to verify for an implementation.

portsmouth commented 7 months ago

A short PR is needed to point this out in the spec.

virtualzavie commented 4 months ago

I think we can close this issue.