Making roughness ranges all [0,1]

AcademySoftwareFoundation / OpenPBR

Specification and reference implementation for the OpenPBR Surface shading model

Apache License 2.0

459 stars 18 forks source link

Making roughness ranges all [0,1] #160

Closed portsmouth closed 7 months ago

portsmouth commented 8 months ago

As discussed in https://github.com/AcademySoftwareFoundation/OpenPBR/issues/143, this PR fixes up the stated roughness ranges to forbid roughness > 1. It isn't useful to allow the roughness to exceed a soft-max at 1, as the appearance is unconvincing (looks like fabric, as the microfacets are mostly vertical -- which is not "rough", and we have a dedicated fuzz layer for this kind of appearance).

portsmouth commented 7 months ago

LGTM. Approved, pending resolution of the conflict between #157 and this one.

Done in https://github.com/AcademySoftwareFoundation/OpenPBR/pull/160/commits/6a164f73df27e4473739cafa4852f77e32b525df.