Rename base_roughness to base_diffuse_roughness

AcademySoftwareFoundation / OpenPBR

Specification and reference implementation for the OpenPBR Surface shading model

Apache License 2.0

401 stars 17 forks source link

Rename base_roughness to base_diffuse_roughness #175

Closed virtualzavie closed 2 months ago

virtualzavie commented 2 months ago

As discussed recently, it would be less ambiguous to name the diffuse roughness base_diffuse_roughness.

portsmouth commented 2 months ago

LGTM. Obviously we're in need of a discussion in the glossy-diffuse section of what base_diffuse_roughness is supposed to mean in terms of the Oren-Nayar model, but that is being discussed in https://github.com/AcademySoftwareFoundation/OpenPBR/pull/174