search

AcademySoftwareFoundation / OpenPBR

Specification and reference implementation for the OpenPBR Surface shading model
Apache License 2.0
401 stars 17 forks source link

Change thin film IOR default #211

Closed portsmouth closed 4 weeks ago

portsmouth commented 1 month ago

From 1.5 to 1.4.

As this won't make much difference to the look in implementations that ignore the adjacent IORs of the film.

But for those that take it into account, this will make the film visible rather than invisible by default (since specular_ior is 1.5 by default, and coat_ior 1.6).

jstone-lucasfilm commented 1 month ago

Since MaterialX also depends on the thin-film IOR in rendering, we should make sure this change is reflected in the MaterialX reference implementation as well.

portsmouth commented 1 month ago

Since MaterialX also depends on the thin-film IOR in rendering, we should make sure this change is reflected in the MaterialX reference implementation as well.

Done in 60f67ef32d7c022daa51ea5e1f554d27c72eacd3