AcademySoftwareFoundation / OpenPBR

Specification and reference implementation for the OpenPBR Surface shading model
Apache License 2.0
474 stars 20 forks source link

transmission_tint? #70

Closed portsmouth closed 8 months ago

portsmouth commented 1 year ago

@brechtvl wrote:

I would suggest to have a distinct non-physical transmission_tint parameter, that works in addition to the colors to control the volume scattering and absorption.

portsmouth commented 1 year ago

If you retain transmission_color for transmission_depth != 0, how do you also use transmission_tint though?

Would this only apply in the transmission_depth= 0 case? It makes the intention clearer, but adds a parameter and maybe seems a bit obscure to users. I wonder what the use cases are for this non-physical transmission tinting, it seems like maybe it could be redundant with e.g. thin-walled glass

portsmouth commented 1 year ago

@brechtvl wrote:

I think it's indeed for something that would be better modeled as thin walled, I don't feel strongly about having this parameter, just that if it is needed it should be separate from the physical color controls instead of having some exception for transmission_depth =0.

portsmouth commented 1 year ago

@peterkutz wrote:

A separate transmission_tint could be useful.

portsmouth commented 8 months ago

Seems like this could be closed, the existing behavior of transmission_color is reasonable.