search

AcademySoftwareFoundation / OpenPBR

Specification and reference implementation for the OpenPBR Surface shading model
Apache License 2.0
425 stars 18 forks source link

Refine MaterialX node names in emission logic #96

Closed portsmouth closed 11 months ago

portsmouth commented 12 months ago

We should account for the opacity of the fuzz_layer here as well (i.e. the emission will be dimmer if passing through a layer of fuzz). Though in the OpenPBR spec we don't propose a formula for that (yet).

portsmouth commented 11 months ago

I disagree as I think the name "blended_coat_emission_edf" is unclear and reads ambiguously (is it a "blended-coat" emission EDF, or a blended "coat emission EDF"? In fact neither of those make sense anyway, the emission is not from the coat but just affected by it) .

The meaning of the node is the final EDF for the surface, and that this involves the coat absorption is a matter for the EDF to compute downstream. I'd rather we don't tie ourselves to historical, unclear names just for the sake of consistency with an old model.