AcademySoftwareFoundation / OpenRV

Open source version of RV, the Sci-Tech award-winning media review and playback software.
Other
550 stars 127 forks source link

[Bug]: OCIO DisplayViewTransform Output is Incorrect (RV 2024.1.0) #437

Open jonahjnewton opened 2 months ago

jonahjnewton commented 2 months ago

What happened?

Pull request #414 fixed an error with using OCIO v2's DisplayViewTransform node.

Using the colorspace below which uses this DisplayViewTransform (also used in issue #403), alongside the ACES 1.0 SDR Rec 709 Display Transform, the output looks correct and there is no longer an error. However as I load a second sequence of media and swap back to the original sequence, the image looks darker than it's supposed to. Moving the sequence onto different monitors also has some strange effects.

- !<ColorSpace>
    name: ACES 1.0 SDR-video (Rec709)
    aliases: [aces_to_rec709_rec1886_ala]
    family: Clipped View Output
    description: |
      ACES ACES 1.0 SDR-video for Rec.709 broadcast monitor with Rec.1886 gamma (2.4)
    isdata: false
    categories: [ file-io ]
    encoding: sdr-video
    from_scene_reference: !<GroupTransform>
      children:
        - !<DisplayViewTransform> {src: ACES2065-1, display: "Rec.1886 Rec.709 - Display", view: "ACES 1.0 - SDR Video"}
        - !<RangeTransform> {min_in_value: 0., min_out_value: 0., max_in_value: 1., max_out_value: 1.}

Any help with this would be very appreciated.

Cheers Jonah

List all the operating systems versions where this is happening

RHEL 7.9

On what computer hardware is this happening?

Memory: 128GB, CPU: Intel® Xeon(R) W-2265 CPU @ 3.50GHz × 24 , GPU: NVIDIA RTX A5000/PCIe/SSE2

Relevant console log output

No response

Environment variables

ALLEGO_LEYFI_STATS_URL=http://roz.ala.int.uts.edu.au:8001/license-info CHROME_CONFIG_HOME=/var/tmp/154522-chrome CREWNAME=jonah.newton CVS_RSH=ssh DEFAULT_PROJECT=s123 DESKTOP_SESSION=gnome DISPLAY=:0 GDMSESSION=gnome GDM_LANG=en_US.UTF-8 GIO_LAUNCHED_DESKTOP_FILE=/usr/share/applications/shotgun.desktop GIO_LAUNCHED_DESKTOP_FILE_PID=8211 GJS_DEBUG_OUTPUT=stderr GJS_DEBUG_TOPICS=JS ERROR;JS LOG GNOME_DESKTOP_SESSION_ID=this-is-deprecated GROUP=animals HISTCONTROL=ignoredups HISTSIZE=1000 HOSTTYPE=x86_64-linux IOCIN_ARGS= --format RGB8_PLANAR --useChromaticities 0 --ioSize 61440 --ioMethod 2 --ioMaxAsync 16 IODPX_ARGS= --format RGB8_PLANAR --useChromaticities 0 --ioSize 61440 --ioMethod 2 --ioMaxAsync 16 IOEXR_ARGS= --rgbaOnly 0 --inherit 1 --noOneChannel 0 --readWindowIsDisplayWindow 0 --readWindow 3 --planar3channel 0 --stripAlpha 0 --convertYRYBY 0 --ioSize 61440 --ioMethod 3 --ioMaxAsync 16 IOJPEG_ARGS= --ioSize 61440 --ioMethod 0 --ioMaxAsync 16 IOTARGA_ARGS= --ioSize 61440 --ioMethod 2 --ioMaxAsync 16 IOTIFF_ARGS= --ioSize 61440 --ioMethod 2 KDEDIRS=/usr LANG=C LC_ALL=C LD_LIBRARY_PATH=/opt/rv-centos7-x86-64-2024.1.0/lib/OpenSSL:/opt/rv-centos7-x86-64-2024.1.0/lib LESSOPEN=||/usr/bin/lesspipe.sh %s MACHTYPE=x86_64 MAIL=/var/spool/mail/154522 MOVIEFFMPEG_ARGS= --defaultFPS 24 MOVIEMISTIKA_ARGS= --format RGB8_PLANAR MU_MODULE_PATH=/home/154522/.rv/Mu:/opt/rv-centos7-x86-64-2024.1.0/plugins/Mu OCIO=/mnt/ala/software/ext_packages/ocio_configs/2.0.2/cg-config-v2.0.0_aces-v1.3-v2.2/studio-config-v2.0.0_aces-v1.3_ocio-v2.2.ocio OCIO_ACTIVE_DISPLAYS=Rec.1886 Rec.709 - Display OCIO_ACTIVE_VIEWS=ACES 1.0 - SDR Video OIIO_LIBRARY_PATH=/home/154522/.rv/OIIO:/opt/rv-centos7-x86-64-2024.1.0/plugins/OIIO:/opt/rv-centos7-x86-64-2024.1.0/plugins/OIIO OPTIONAL_PADSP= ORIGINALLOCAL=en OSTYPE=linux OTIO_PLUGIN_MANIFEST_PATH=/opt/rv-centos7-x86-64-2024.1.0/plugins/Python/../SupportFiles/otio_reader/manifest.json P4CONFIG=.p4config PATH=/opt/rv-centos7-x86-64-2024.1.0/bin:/mnt/ala/software/ext_packages/rv/2024.1.0/bin:/opt/rv-centos7-x86-64-2024.1.0/bin:/mnt/ala/software/int_packages/shotgun_utils/0.2.5/bin:/mnt/ala/software/int_packages/shotgun_utils/0.2.5/python:/usr/local/bin:/usr/bin:/bin PROJ_ROOT=/mnt/ala/mav/2024/jobs/s124 PROJ_WIP_ROOT=/mnt/ala/mav/2024/wip/s124 PWD=/home/154522 PYTHONHOME=/opt/rv-centos7-x86-64-2024.1.0 PYTHONPATH=/opt/rv-centos7-x86-64-2024.1.0/lib:/opt/rv-centos7-x86-64-2024.1.0/lib/lib-dynload:/mnt/ala/software/int_packages/shotgun_utils/0.2.5/python:/mnt/ala/mav/pipeline/config/studio/install/core/python:/mnt/ala/software/int_packages/shotgun_utils/0.2.5/python:/mnt/ala/mav/pipeline/config/studio/install/core/python:/home/154522/.rv/Python:/opt/rv-centos7-x86-64-2024.1.0/plugins/Python:/opt/rv-centos7-x86-64-2024.1.0/plugins/MediaLibrary QTDIR=/usr/lib64/qt-3.3 QTINC=/usr/lib64/qt-3.3/include QTLIB=/usr/lib64/qt-3.3/lib QT_GRAPHICSSYSTEM_CHECKED=1 QT_IM_MODULE=ibus QT_QUICK_BACKEND=software QT_XCB_TABLET_LEGACY_COORDINATES=1 REZ_CONFIG_FILE=/mnt/ala/software/pipeline/config/rezconfig.py REZ_CONTEXT_FILE=/tmp/rez_context_xSQSDN/context.sh REZ_ENV_PROMPT=>> REZ_OCIO_CONFIGS_BASE=/mnt/ala/software/ext_packages/ocio_configs/2.0.2 REZ_OCIO_CONFIGS_MAJOR_VERSION=2 REZ_OCIO_CONFIGS_MINOR_VERSION=0 REZ_OCIO_CONFIGS_PATCH_VERSION=2 REZ_OCIO_CONFIGS_ROOT=/mnt/ala/software/ext_packages/ocio_configs/2.0.2 REZ_OCIO_CONFIGS_VERSION=2.0.2 REZ_PATH=/mnt/ala/software/ext_packages/rez/2.112/platform-linux/arch-x86_64/python-2/os-RedHatEnterpriseServer-6.8/rez/../rez REZ_RAW_REQUEST=s124 rv-2024 ocio_configs-2.0.2 ~platform==linux ~arch==x86_64 studio_ala shotgun_utils REZ_REQUEST=s124 rv-2024 ocio_configs-2.0.2 ~platform==linux ~arch==x86_64 studio_ala shotgun_utils REZ_RESOLVE=s124-0.0.0 rv-2024.1.0 ocio_configs-2.0.2 studio_ala-1.5.0 shotgun_utils-0.2.5 REZ_RESOLVE_MODE=latest REZ_RV_BASE=/mnt/ala/software/ext_packages/rv/2024.1.0 REZ_RV_MAJOR_VERSION=2024 REZ_RV_MINOR_VERSION=1 REZ_RV_PATCH_VERSION=0 REZ_RV_ROOT=/mnt/ala/software/ext_packages/rv/2024.1.0 REZ_RV_VERSION=2024.1.0 REZ_RXT_FILE=/tmp/rez_context_xSQSDN/context.rxt REZ_S124_BASE=/mnt/ala/software/int_packages/s124/0.0.0 REZ_S124_MAJOR_VERSION=0 REZ_S124_MINOR_VERSION=0 REZ_S124_PATCH_VERSION=0 REZ_S124_ROOT=/mnt/ala/software/int_packages/s124/0.0.0 REZ_S124_VERSION=0.0.0 REZ_SHELL_INIT_TIMESTAMP=1709768094 REZ_SHELL_INTERACTIVE=0 REZ_SHOTGUN_DESKTOP_BASE=/mnt/ala/software/ext_packages/shotgun_desktop/2.1.8 REZ_SHOTGUN_DESKTOP_MAJOR_VERSION=2 REZ_SHOTGUN_DESKTOP_MINOR_VERSION=1 REZ_SHOTGUN_DESKTOP_PATCH_VERSION=8 REZ_SHOTGUN_DESKTOP_ROOT=/mnt/ala/software/ext_packages/shotgun_desktop/2.1.8 REZ_SHOTGUN_DESKTOP_VERSION=2.1.8 REZ_SHOTGUN_UTILS_BASE=/mnt/ala/software/int_packages/shotgun_utils/0.2.5 REZ_SHOTGUN_UTILS_MAJOR_VERSION=0 REZ_SHOTGUN_UTILS_MINOR_VERSION=2 REZ_SHOTGUN_UTILS_PATCH_VERSION=5 REZ_SHOTGUN_UTILS_ROOT=/mnt/ala/software/int_packages/shotgun_utils/0.2.5 REZ_SHOTGUN_UTILS_VERSION=0.2.5 REZ_STORED_PROMPT_SH= REZ_STUDIO_ALA_BASE=/mnt/ala/software/int_packages/studio_ala/1.5.0 REZ_STUDIO_ALA_MAJOR_VERSION=1 REZ_STUDIO_ALA_MINOR_VERSION=5 REZ_STUDIO_ALA_PATCH_VERSION=0 REZ_STUDIO_ALA_ROOT=/mnt/ala/software/int_packages/studio_ala/1.5.0 REZ_STUDIO_ALA_VERSION=1.5.0 REZ_TK_SUITE_BASE=/mnt/ala/software/int_packages/tk_suite/0.1.3 REZ_TK_SUITE_MAJOR_VERSION=0 REZ_TK_SUITE_MINOR_VERSION=1 REZ_TK_SUITE_PATCH_VERSION=3 REZ_TK_SUITE_ROOT=/mnt/ala/software/int_packages/tk_suite/0.1.3 REZ_TK_SUITE_VERSION=0.1.3 REZ_USED=/mnt/ala/software/ext_packages/rez/2.112/platform-linux/arch-x86_64/python-2/os-RedHatEnterpriseServer-6.8/rez/../rez REZ_USED_IMPLICIT_PACKAGES=~platform==linux ~arch==x86_64 studio_ala shotgun_utils REZ_USED_PACKAGES_PATH=/home/154522/packages:/mnt/ala/software/int_packages:/mnt/ala/software/ext_packages REZ_USED_REQUEST=s124 rv-2024 ocio_configs-2.0.2 REZ_USED_REQUESTED_TIMESTAMP=0 REZ_USED_RESOLVE=s124-0.0.0 rv-2024.1.0 ocio_configs-2.0.2 studio_ala-1.5.0 shotgun_utils-0.2.5 REZ_USED_TIMESTAMP=1709768094 REZ_USED_VERSION=2.112.0 REZ_VERSION=2.112.0 RVPUSH_BIN=rvpush RV_APP_GTO_REFERENCE= RV_APP_INIT=/opt/rv-centos7-x86-64-2024.1.0/scripts/rv/rvrc.mu RV_APP_LICENSES_NOTES= RV_APP_MANUAL= RV_APP_MANUAL_HTML= RV_APP_MU_MANUAL= RV_APP_PYINIT=/opt/rv-centos7-x86-64-2024.1.0/scripts/rv/rvrc.py RV_APP_REFERENCE_MANUAL= RV_APP_REFERENCE_MANUAL_HTML= RV_APP_RELEASE_NOTES= RV_APP_RV=/opt/rv-centos7-x86-64-2024.1.0/bin/rv RV_APP_RVIO=/opt/rv-centos7-x86-64-2024.1.0/bin/rvio RV_APP_RV_SHORT_NAME=rv RV_APP_SDI_MANUAL= RV_APP_SDI_MANUAL_HTML= RV_BIN=rv RV_DARK=1 RV_HOME=/opt/rv-centos7-x86-64-2024.1.0 RV_LOCATION=/opt/rv-centos7-x86-64-2024.1.0/bin RV_OCIO_DISPLAY=Rec.1886 Rec.709 - Display RV_OCIO_INSPACE_EXR=ACES - ACEScg RV_OCIO_INSPACE_PNG=aces_to_rec709_rec1886_ala RV_OCIO_VIEW=ACES 1.0 - SDR Video RV_PYTHONHOME_EXTERNAL= RV_PYTHONPATH_EXTERNAL=/mnt/ala/software/int_packages/shotgun_utils/0.2.5/python:/mnt/ala/mav/pipeline/config/studio/install/core/python:/mnt/ala/software/int_packages/shotgun_utils/0.2.5/python:/mnt/ala/mav/pipeline/config/studio/install/core/python SESSION_MANAGER=local/unix:@/tmp/.ICE-unix/7238,unix/unix:/tmp/.ICE-unix/7238 SGTK_DEFAULT_AUTH_METHOD=app_session_launcher SGTK_DESKTOP_ORIGINAL_PYTHONPATH=/mnt/ala/software/int_packages/shotgun_utils/0.2.5/python:/mnt/ala/mav/pipeline/config/studio/install/core/python SHARED_TANK_PATH=/mnt/ala/mav/pipeline/config/studio/install/core/python SHELL=/bin/bash SHLVL=5 SHOTGUN_INFO=/mnt/ala/software/int_packages/shotgun_utils/0.2.5/config/shotgun.json SHOTGUN_PROJECT=s124 SHOTGUN_PYTHON_VERSION=3 SHOTGUN_UTILS_PATH=/mnt/ala/software/int_packages/shotgun_utils/0.2.5/python/shotgun_utils STUDIO_NAME=studio_ala SUBSTANCE_PAINTER_PLUGINS_PATH=/home/154522/git/substance_pipeline/ TANK_CURRENT_PC=/opt/rv-centos7-x86-64-2024.1.0/src/sgtk/baked/plugin/bundle_cache/baked/tk-config-rv/v2.0.6 TERM=xterm TK_AUTH_PRODUCT=RV TK_RV_MODE_NAME=sgtk_bootstrap TWK_APP_SUPPORT_PATH=/home/154522/.rv:/opt/rv-centos7-x86-64-2024.1.0/plugins TWK_APP_VERSION=2024.1.0 TWK_FB_PLUGIN_PATH=/home/154522/.rv/ImageFormats:/opt/rv-centos7-x86-64-2024.1.0/plugins/ImageFormats TWK_MEDIA_LIBRARY_PLUGIN_PATH=/opt/rv-centos7-x86-64-2024.1.0/plugins/MediaLibrary TWK_MOVIE_PLUGIN_PATH=/home/154522/.rv/MovieFormats:/opt/rv-centos7-x86-64-2024.1.0/plugins/MovieFormats TWK_NODE_PLUGIN_PATH=/home/154522/.rv/Nodes:/opt/rv-centos7-x86-64-2024.1.0/plugins/Nodes TWK_OUTPUT_PLUGIN_PATH=/opt/rv-centos7-x86-64-2024.1.0/plugins/Output TWK_PROFILE_PLUGIN_PATH=/home/154522/.rv/Profiles:/opt/rv-centos7-x86-64-2024.1.0/plugins/Profiles TWK_RVIO_SETUP=10315 USER=154522 USERNAME=154522 USE_REZ_CACHE=1 VENDOR=unknown WINDOWID=75497506 WINDOWPATH=1 XAUTHORITY=/run/gdm/auth-for-154522-X9dWU5/database XDG_CURRENT_DESKTOP=GNOME XDG_DATA_DIRS=/home/154522/.local/share/flatpak/exports/share/:/var/lib/flatpak/exports/share/:/usr/local/share/:/usr/share/:/var/lib/snapd/desktop XDG_MENU_PREFIX=gnome- XDG_RUNTIME_DIR=/run/user/200154522 XDG_SEAT=seat0 XDG_SESSION_DESKTOP=gnome XDG_SESSION_ID=5 XDG_SESSION_TYPE=x11 XDG_VTNR=1 XMODIFIERS=@im=ibus XTERM_LOCALE=en_US.UTF-8 XTERM_SHELL=/mnt/ala/software/ext_packages/rv/2024.1.0/bin/rv_run XTERM_VERSION=X.Org 7.6.0(295) force_s3tc_enable=true

Extra information

Steps to replicate:

  1. Add ColorSpace in bug description into OCIO config.
  2. Load this ColorSpace in RV.
  3. Load a second sequence of media
  4. Swap between the sequences of media in the Session manager

Code of Conduct

fabiangeisler commented 1 month ago

Hi @jonahjnewton ! I cannot contribute anything to this issue, just want to recommend to you to obfuscate your environment variables a bit more. The SHOTGUN_DESKTOP_CURRENT_USER contains a session key that could give me (temporary) access to your Flow Production Tracking. There also seems to be a permanent API key SG_API_KEY. Hope that helps.

jonahjnewton commented 1 month ago

Hi @jonahjnewton !

I cannot contribute anything to this issue, just want to recommend to you to obfuscate your environment variables a bit more. The SHOTGUN_DESKTOP_CURRENT_USER contains a session key that could give me (temporary) access to your Flow Production Tracking. There also seems to be a permanent API key SG_API_KEY.

Hope that helps.

🫣 Good to know, thanks for notifying me!