AcademySoftwareFoundation / OpenRV

Open source version of RV, the Sci-Tech award-winning media review and playback software.
Other
550 stars 127 forks source link

Enable PNG decoder on Windows #448

Closed cedrik-fuoco-adsk closed 2 months ago

cedrik-fuoco-adsk commented 2 months ago

Enable PNG decoder on Windows

Linked issues

447

Summarize your change.

Make sure that FFmpeg knows where to find ZLIB library. ZLIB is needed by the PNG decoder.

ZLIB had to be patched to be used during FFmpeg build on Windows. Note that the patch comes from the ZLIB port of Vcpkg.

Describe the reason for the change.

PNG movies were not able to be decoded because PNG decoder in FFmpeg was disabled due to missing ZLIB library during the build of FFmpeg.

Since ZLIB is installed by default on MacOS and Linux, it wasn't a problem on those systems. But it means that the wrong ZLIB was used by FFmpeg (not the one compiled by OpenRV).

Describe what you have tested and on which operating system.

Add a list of changes, and note any that might need special attention during the review.

n/a

If possible, provide screenshots.

n/a