[x] Fix issue with OTIO in debug on Windows by specifying the library file and includes directly to CMake.
[x] Fix an issue in debug on Windows where ZLIB (release) was found in MinGW system files and where ZLIB was found in RV_DEPS_ZLIB (debug). Both were linked and it was causing issue with minizip-ng. I think it is an issue with minizip-ng, but the fix makes sure that we only linked to the right one.
[x] Sets IMPORTED_IMPLIB for SSL and Crypto target on Windows
[x] Use CMake instead of the configure script and make for PCRE2 (Windows only).
Describe the reason for the change.
Long standing instability with OTIO in debug on Windows. I always had issues building OpenRV in debug on Windows due to OTIO. This PR makes the debug build more stable, and I can build OpenRV in debug straight from a fresh cloned repository.
Describe what you have tested and on which operating system.
[x] Windows
Add a list of changes, and note any that might need special attention during the review.
Fix issue with OTIO in debug on Windows
Linked issues
n/a
Summarize your change.
OTIO
in debug on Windows by specifying the library file and includes directly to CMake.ZLIB (release)
was found in MinGW system files and whereZLIB
was found in RV_DEPS_ZLIB (debug). Both were linked and it was causing issue withminizip-ng
. I think it is an issue withminizip-ng
, but the fix makes sure that we only linked to the right one.IMPORTED_IMPLIB
forSSL
andCrypto
target on WindowsCMake
instead of the configure script and make for PCRE2 (Windows only).Describe the reason for the change.
Long standing instability with OTIO in debug on Windows. I always had issues building OpenRV in debug on Windows due to OTIO. This PR makes the debug build more stable, and I can build OpenRV in debug straight from a fresh cloned repository.
Describe what you have tested and on which operating system.
Add a list of changes, and note any that might need special attention during the review.
n/a
If possible, provide screenshots.
n/a