Closed chxmberland closed 3 months ago
Looks good to me. Question: Where is the rvpkgs content extracted before being added to the rvpkg args?
Directly into the location that the user requests. This is specified explicitly if using the command line, but selected from a list of two locations when using the UI.
Linked issues
Summarize your change.
Users can now upload multiple packages at the same time through a compressed zip file using the extension .rvpkgs. These .rvpkgs files can be uploaded using the
rvpkg -add ...
command in the shell, or directly in the UI under thePreferences/Packages
section of the menu.In either case, .rvpkgs files will be immediately unzipped into the packages they contain before each package is added to OpenRV.
Users can also add and install these .rvpkgs bundles using a chain command as follows.
rvpkg -force -install -add <destination> <location of .rvpkgs file>
Describe the reason for the change.
Describe what you have tested and on which operating system.
This change was tested on MacOS. To replicate the test, recreate the following steps.
Creating an .rvpkgs file
<name>-<version>.rvpkgs
Testing UI upload
Preferences/Packages
section of the menuAdd Packages...
Testing Command Line
rvpkg -force -install -add <destination> <location of .rvpkgs file>
rvpkg -add <destination> <location of .rvpkgs file>
Note that packages are often installed to
~/Library/Application\ Support/RV/
on Mac.Add a list of changes, and note any that might need special attention during the review.