AcademySoftwareFoundation / OpenRV

Open source version of RV, the Sci-Tech award-winning media review and playback software.
Other
577 stars 142 forks source link

Fix FFmpeg 6.0 crashes when loading 50+ clips and stressing the timeline #484

Closed bernie-laberge closed 3 months ago

bernie-laberge commented 4 months ago

483: Fix FFmpeg 6.0 crashes when loading 50+ clips and stressing the timeline

Linked issues

Fixes #483

Summarize your change.

No longer using the MovieFFMpeg global context pool (since FFmpeg 6.0)

Describe the reason for the change.

Rationale: The global context pool was based on the premise that a context could be opened and closed multiple times. However, with FFmpeg 6.0, this premise is no longer valid and was causing crashes. As per the FFmpeg 6 documentation: https://ffmpeg.org/doxygen/trunk/deprecated.html: "Opening and closing a codec context multiple times is not supported anymore – use multiple codec contexts instead."

Describe what you have tested and on which operating system.

Successfully validated repro steps

Add a list of changes, and note any that might need special attention during the review.

If possible, provide screenshots.