Open mamouth13 opened 3 months ago
Bonjour @mamouth13 , We apologize for the delay in reviewing your pull requests due to the fact that some key reviewers were on vacation.
Thank you for this excellent contribution to the Open RV effort !
Hi Bernard You are welcome 😉 TL
Le mar. 16 juil. 2024, 15:38, Bernard Laberge @.***> a écrit :
Bonjour @mamouth13 https://github.com/mamouth13 , We apologize for the delay in reviewing your pull requests due to the fact that some key reviewers were on vacation.
Thank you for this excellent contribution to the Open RV effort !
— Reply to this email directly, view it on GitHub https://github.com/AcademySoftwareFoundation/OpenRV/pull/498#issuecomment-2230918943, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDAOIQ6AHYFARN4LYN4M6ATZMUO6HAVCNFSM6AAAAABJ2F4J72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZQHEYTQOJUGM . You are receiving this because you were mentioned.Message ID: @.***>
OnionSkin management in annotation
Modifications
Added 5 properties into the
PaintIPNode
node:onionShow
: enabled/disabled the drawing of onionSkin (default is false).onionBeforeFrame
: the number of frames BEFORE a stroke on which the onionSkins will be drawn (default is 5).onionAfterFrame
: the number of frames AFTER a stroke on which the onionSkins will be drawn (default is 5).onionBeforeColor
: the color used to draw onionSkin BEFORE (default is red).onionAfterColor
: the color used to draw onionSkin AFTER (default is green).Paint::PolyLine
andPaint::Text
now manage those new properties and draw onionSkin on previous / next frames with the appropriate fading out colors.Modified the annotate rv-package:
drawpane.ui
to add the appropriate Ui to manage the above new properties.annotate_mode.mu
to properly handle the colorChooser with those new Ui.Tests
This has been tested on CentOS Linux 7.
Screenshot