search

AcademySoftwareFoundation / OpenRV

Open source version of RV, the Sci-Tech award-winning media review and playback software.
Other
577 stars 142 forks source link

Automatically set QT_HOME variable if it is not already set #501

Closed chxmberland closed 3 months ago

chxmberland commented 3 months ago

Linked issues

502

Summarize your change.

When RV is built, we now search for QT_HOME (the QT installation location), rather than assuming it.

Describe the reason for the change.

Some customers have reported having issues with QT_HOME not being set correctly due to the static assumption we have made about the installation location of QT.

Describe what you have tested and on which operating system.

QT_HOME is set properly, regardless of QT installation location, for macOS Sonoma 14.5 and Windows 11. L

Add a list of changes, and note any that might need special attention during the review.

geffrak commented 2 months ago

@bernie-laberge, someone with both Qt 6 and Qt 5 might end in a different situation than you what expect. We should check against 5.15, which is the only thing RV supports.

Also, on Mac, the/macOS (fat binary) works well, too, not just clang_64. I've been using this for a while now. It doesn't break the Intel build and is required for the Apple Silicon one.

Finally, 5.15.2 is the more recent version that is provided by Qt without a commercial licence, that's why it was the default value.

bernie-laberge commented 2 months ago

Good catch @geffrak . I'll create a ticket to address those issues you raised. Thanks!